From 9bb270086f78d8377c064f1f28082e5338c16208 Mon Sep 17 00:00:00 2001 From: Keir Fraser Date: Thu, 13 May 2010 09:44:20 +0100 Subject: [PATCH] x86: Fix a few on_{selected,each}_cpus callers who should wait for completion. Signed-off-by: Keir Fraser --- xen/arch/x86/acpi/cpufreq/cpufreq.c | 2 +- xen/arch/x86/acpi/cpufreq/powernow.c | 2 +- xen/arch/x86/cpu/mcheck/mce.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/arch/x86/acpi/cpufreq/cpufreq.c b/xen/arch/x86/acpi/cpufreq/cpufreq.c index 6948d7d816..c0b2d94d65 100644 --- a/xen/arch/x86/acpi/cpufreq/cpufreq.c +++ b/xen/arch/x86/acpi/cpufreq/cpufreq.c @@ -195,7 +195,7 @@ static void drv_write(struct drv_cmd *cmd) cpu_isset(smp_processor_id(), cmd->mask)) do_drv_write((void *)cmd); else - on_selected_cpus(&cmd->mask, do_drv_write, cmd, 0); + on_selected_cpus(&cmd->mask, do_drv_write, cmd, 1); } static u32 get_cur_val(cpumask_t mask) diff --git a/xen/arch/x86/acpi/cpufreq/powernow.c b/xen/arch/x86/acpi/cpufreq/powernow.c index 27b53372d2..18538fdc49 100644 --- a/xen/arch/x86/acpi/cpufreq/powernow.c +++ b/xen/arch/x86/acpi/cpufreq/powernow.c @@ -137,7 +137,7 @@ static int powernow_cpufreq_target(struct cpufreq_policy *policy, cmd.val = next_perf_state; cmd.turbo = policy->turbo; - on_selected_cpus(&cmd.mask, transition_pstate, &cmd, 0); + on_selected_cpus(&cmd.mask, transition_pstate, &cmd, 1); for_each_cpu_mask(j, online_policy_cpus) cpufreq_statistic_update(j, perf->state, next_perf_state); diff --git a/xen/arch/x86/cpu/mcheck/mce.c b/xen/arch/x86/cpu/mcheck/mce.c index 33e5bcb480..cf0ca5fec4 100644 --- a/xen/arch/x86/cpu/mcheck/mce.c +++ b/xen/arch/x86/cpu/mcheck/mce.c @@ -1421,7 +1421,7 @@ long do_mca(XEN_GUEST_HANDLE(xen_mc_t) u_xen_mc) add_taint(TAINT_ERROR_INJECT); if ( mce_broadcast ) - on_each_cpu(x86_mc_mceinject, mc_mceinject, 0); + on_each_cpu(x86_mc_mceinject, mc_mceinject, 1); else on_selected_cpus(cpumask_of(target), x86_mc_mceinject, mc_mceinject, 1); -- 2.30.2